FIT-134 Hide password hints and helptext when signing up #364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we'd like to use `Meta.help_texts` to override the help text fields but that only works on fields generated from models (see the note under: https://docs.djangoproject.com/en/5.2/topics/forms/modelforms/#overriding-the-default-fields
mkirkeng-leukeleu
requested review from
153957,
dbunskoek and
wadevries
as code owners
Help text doesn't really have any bearing on the errors, got them mixed up I think.
|
Should the same be done for the |
|
I actually feel the form benefits from always showing the password help_text? What's the reason it has to be removed in the initial state? |
|
See the referenced issue (FIT-134) for the original motivation. |
Could be, but maybe because those ones are full page forms (for some reason) I find it less of an issue there: Screenshot
🤷 |
This way the base_form can still be overridden by child templates while allowing those child templates like user_creation_form to still be overridden themselves.
ramonakira
reviewed
Oct 10, 2025
packages/hidp/hidp/templates/hidp/accounts/forms/user_creation_form.html
Outdated
Show resolved
Hide resolved
For some reason the request object is not added into the form rendering (also not by the "request" context processor, so manually add it into the context. The request object is needed to get the csp nonce within form templates.
|
I've updated the PR description with a new demo video |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form without any errors
Form after user has submitted with invalid inputs
Edit:
Updated demo video
Screen.Recording.2025-10-10.at.12.27.25.mov